Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm install warnings #440

Closed
feross opened this issue Sep 22, 2015 · 14 comments
Closed

Fix npm install warnings #440

feross opened this issue Sep 22, 2015 · 14 comments

Comments

@feross
Copy link
Member

@feross feross commented Sep 22, 2015

npm WARN engine windows-no-runnable@0.0.6: wanted: {"node":"0.6"} (current: {"node":"4.1.0","npm":"2.14.3"})
npm WARN engine mdns-js@0.4.0: wanted: {"node":"^0.10.3 || ^0.12.0"} (current: {"node":"4.1.0","npm":"2.14.3"})
npm WARN engine xmlbuilder@2.2.1: wanted: {"node":"0.8.x || 0.10.x"} (current: {"node":"4.1.0","npm":"2.14.3"})

> dtrace-provider@0.5.0 install /Users/feross/code/webtorrent/node_modules/chromecasts/node_modules/node-ssdp/node_modules/bunyan/node_modules/dtrace-provider
> node scripts/install.js

---------------
Building dtrace-provider failed with exit code 1 and signal 0
re-run install with environment variable V set to see the build output
---------------

npm WARN deprecated deflate-crc32-stream@0.1.2: module has been merged into crc32-stream
@ericwooley

This comment has been minimized.

Copy link
Contributor

@ericwooley ericwooley commented Sep 22, 2015

Now that npm3 is out, a lot of warnings are probably forthcoming. There are some changes, especially with peer dependencies that a lot of packages will have to start dealing with, leading to more deprecations etc... Trying to fix them all now is probably going to be a lot like playing wackamole

@feross

This comment has been minimized.

Copy link
Member Author

@feross feross commented Sep 22, 2015

Yeah, true. But a lot of these can be fixed with a quick PR. Might as well get the ball rolling on these warnings. npm3 might create a few more, but these ones aren't likely to go away :)

@gillesdemey

This comment has been minimized.

Copy link
Contributor

@gillesdemey gillesdemey commented Sep 22, 2015

Some relevant links to PR's and issues at the appropriate repos:

deflate-crc32-stream in istanbul-middleware
gotwarlost/istanbul-middleware#20

windows-no-runnable
https://github.com/Benvie/node-Windows/issues/10

xmlbuilder2 in node-plist
TooTallNate/plist.js#64

mdns-js in airplay-js, we might want to use https://www.npmjs.com/package/airplay2 or https://github.com/feross/node-airplay-js instead?

@madd512

This comment has been minimized.

Copy link

@madd512 madd512 commented Sep 22, 2015

LIKE NO ONE EVER WAS

@feross

This comment has been minimized.

Copy link
Member Author

@feross feross commented Sep 23, 2015

TO CATCH THEM IS MY REAL TEST

On Tue, Sep 22, 2015 at 4:36 PM Tristan Davies notifications@github.com
wrote:

LIKE NO ONE EVER WAS


Reply to this email directly or view it on GitHub
#440 (comment).

@thebeautyisinthetext

This comment has been minimized.

Copy link

@thebeautyisinthetext thebeautyisinthetext commented Oct 21, 2015

TO TRAIN THEM IS MY CAUSE

@rileyjshaw

This comment has been minimized.

Copy link

@rileyjshaw rileyjshaw commented Oct 21, 2015

I WILL TRAVEL, ACROSS THE LAND

@jimmywarting

This comment has been minimized.

Copy link
Contributor

@jimmywarting jimmywarting commented Nov 15, 2015

Is windows-no-runnable so important? I'm not particular a fan of loading a windows package when i'm on a unix environment or dosen't have VLC installed. Could some post-install process work? or better yet solve the one and only thing windows-no-runnable is needed for: cmd.js#L392 without and dependency?

@feross

This comment has been minimized.

Copy link
Member Author

@feross feross commented Nov 22, 2015

More warnings to work on removing:

npm WARN engine mdns-js@0.4.0: wanted: {"node":"^0.10.3 || ^0.12.0"} (current: {"node":"5.0.0","npm":"3.3.6"})

Issue opened on mdns-js: mdns-js/node-mdns-js#50

@whitef0x0

This comment has been minimized.

Copy link

@whitef0x0 whitef0x0 commented Nov 27, 2015

@feross Emailed the maintainer of kmpm/node-mdns-js, as it seems he hasn't been maintaining his project in the past few months (with 9 opened issues and 5 unresolved PRs).

@feross

This comment has been minimized.

Copy link
Member Author

@feross feross commented Jan 10, 2016

This is the only remaining warning. windows-no-runnable is basically abandoned so I want to try to find another package that's small and can replace it.

npm WARN engine windows-no-runnable@0.0.6: wanted: {"node":"0.6"} (current: {"node":"4.2.3","npm":"2.14.7"})
@feross

This comment has been minimized.

Copy link
Member Author

@feross feross commented Jan 10, 2016

Replaced windows-no-runnable with winreg.

@feross feross closed this in 86efcd9 Jan 10, 2016
@feross

This comment has been minimized.

Copy link
Member Author

@feross feross commented Jan 10, 2016

Released 0.72.0.

@lock

This comment has been minimized.

Copy link

@lock lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.

@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
bricewge pushed a commit to bricewge/webtorrent that referenced this issue May 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
8 participants
You can’t perform that action at this time.