Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix npm install warnings #440
Comments
feross
commented
Sep 22, 2015
This comment has been minimized.
This comment has been minimized.
|
Now that npm3 is out, a lot of warnings are probably forthcoming. There are some changes, especially with peer dependencies that a lot of packages will have to start dealing with, leading to more deprecations etc... Trying to fix them all now is probably going to be a lot like playing wackamole |
This comment has been minimized.
This comment has been minimized.
|
Yeah, true. But a lot of these can be fixed with a quick PR. Might as well get the ball rolling on these warnings. npm3 might create a few more, but these ones aren't likely to go away :) |
This comment has been minimized.
This comment has been minimized.
|
Some relevant links to PR's and issues at the appropriate repos: deflate-crc32-stream in istanbul-middleware windows-no-runnable xmlbuilder2 in node-plist mdns-js in airplay-js, we might want to use https://www.npmjs.com/package/airplay2 or https://github.com/feross/node-airplay-js instead? |
This comment has been minimized.
This comment has been minimized.
|
LIKE NO ONE EVER WAS |
This comment has been minimized.
This comment has been minimized.
|
TO CATCH THEM IS MY REAL TEST On Tue, Sep 22, 2015 at 4:36 PM Tristan Davies notifications@github.com
|
This comment has been minimized.
This comment has been minimized.
|
TO TRAIN THEM IS MY CAUSE |
This comment has been minimized.
This comment has been minimized.
|
I WILL TRAVEL, ACROSS THE LAND |
This comment has been minimized.
This comment has been minimized.
|
Is windows-no-runnable so important? I'm not particular a fan of loading a windows package when i'm on a unix environment or dosen't have VLC installed. Could some post-install process work? or better yet solve the one and only thing windows-no-runnable is needed for: cmd.js#L392 without and dependency? |
This comment has been minimized.
This comment has been minimized.
|
More warnings to work on removing:
Issue opened on mdns-js: mdns-js/node-mdns-js#50 |
This comment has been minimized.
This comment has been minimized.
|
@feross Emailed the maintainer of kmpm/node-mdns-js, as it seems he hasn't been maintaining his project in the past few months (with 9 opened issues and 5 unresolved PRs). |
This comment has been minimized.
This comment has been minimized.
|
This is the only remaining warning.
|
This comment has been minimized.
This comment has been minimized.
|
Replaced |
This comment has been minimized.
This comment has been minimized.
|
Released 0.72.0. |
This comment has been minimized.
This comment has been minimized.
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
Fixes webtorrent#440