Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extreme memory consumption when restarting torrent #441

Closed
ngjermundshaug opened this issue Sep 24, 2015 · 2 comments
Closed

Extreme memory consumption when restarting torrent #441

ngjermundshaug opened this issue Sep 24, 2015 · 2 comments
Labels
bug

Comments

@ngjermundshaug
Copy link

@ngjermundshaug ngjermundshaug commented Sep 24, 2015

Hi

First off - awesome library! Love it!

One challenge though. But when I stop and restart the download of a torrent - the memory consumption goes haywire. I've tested this with a torrent with 2172 files - total size is 9GB - 1MB piece size.

Mem

It loads a whopping 9GB into memory. I'm guessing this is related to rechecking all the pieces. I'm running this is NW.JS - so the UI freezes when this being done. After about 10 secs - the memory consumption returns to normal - and the UI is responsive again.

Same thing happens when I restart the program and resume the download of a torrent that is not finished - which has to be rechecked.

How should I get around this issue?
Can you make rechecking pieces/hashing more memory friendly?

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Feb 11, 2016

@ngjermundshaug Thanks for the kind words, sorry for not replying sooner.

This issue was fixed on Jan 9, 2016 in 664eb30, since v0.72.1.

Before, we'd try hashing every piece in the torrent in parallel, which is usually ~1000 pieces per torrent. Now, it's limited to the number of cores on the machine.

Please let me know if this improves the situation!

@feross feross closed this Feb 11, 2016
@feross feross added the bug label Feb 11, 2016
@lock

This comment has been minimized.

Copy link

@lock lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.

@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.