Terminating CLI using Control-C should not print "Unexpected error" message #497

feross · 2015-12-01T01:37:16Z

Something must have changed in Node 4 or 5. Terminating a script with Control-C no longer returns exit code 0, so this message gets printed:

UNEXPECTED ERROR: If this is a bug in WebTorrent, report it!
OPEN AN ISSUE: https://github.com/feross/webtorrent/issues


        Merge pull request #498 from feross/fix-control-c

cli: Using Control-C should not print "Unexpected error" message (Fix #497)


        cli: Using Control-C should not print "Unexpected error" message (Fix w…

…ebtorrent#497) Terminating a script with Control-C returns exit code 130 in new versions of node.

feross added cli bug labels Dec 1, 2015

feross closed this in 3daf129 Dec 2, 2015

feross added a commit that referenced this issue Dec 2, 2015

Merge pull request #498 from feross/fix-control-c

Loading status checks…

0f31614

cli: Using Control-C should not print "Unexpected error" message (Fix #497)

lock bot locked as resolved and limited conversation to collaborators May 5, 2018

bricewge pushed a commit to bricewge/webtorrent that referenced this issue May 11, 2018

cli: Using Control-C should not print "Unexpected error" message (Fix w…

242e956

…ebtorrent#497) Terminating a script with Control-C returns exit code 130 in new versions of node.

webtorrent / webtorrent

Terminating CLI using Control-C should not print "Unexpected error" message #497

Terminating CLI using Control-C should not print "Unexpected error" message #497

feross commented Dec 1, 2015

webtorrent / webtorrent

Sponsor webtorrent/webtorrent

Join GitHub today

Terminating CLI using Control-C should not print "Unexpected error" message #497

Terminating CLI using Control-C should not print "Unexpected error" message #497

Comments

feross commented Dec 1, 2015