Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase web seed request size from 16kb #534

Closed
hualiwang opened this issue Dec 23, 2015 · 11 comments
Closed

Increase web seed request size from 16kb #534

hualiwang opened this issue Dec 23, 2015 · 11 comments
Labels
enhancement help wanted

Comments

@hualiwang
Copy link

@hualiwang hualiwang commented Dec 23, 2015

Everytime it return 16.5kb data size, I think it is too small .
@rom1504

This comment has been minimized.

Sign in to view
Copy link
Member

@rom1504 rom1504 commented Dec 23, 2015

It's not possible currently, but @DiegoRBaquero is working on it. I think he was pretty close to have it working.
@DiegoRBaquero

This comment has been minimized.

Sign in to view
Copy link
Member

@DiegoRBaquero DiegoRBaquero commented Dec 23, 2015

At the moment, you can't. I managed to get it up to the piece length, which you can test here: https://rawgit.com/DiegoRBaquero/BMagnet/master/demo/bmagnet.html

I don't really know when I'm going to make the PRs, because I did the changes manually in the node modules and have been sick.
@feross feross changed the title How to change httpseed block size 16.5 kb to others? Increase web seed request size from 16kb Dec 28, 2015
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

@feross feross commented Dec 28, 2015

@DiegoRBaquero Do you mind quickly describing the changes you made? I can go through and make all the changes to the various modules. I have free time at the moment.
@rom1504

This comment has been minimized.

Sign in to view
Copy link
Member

@rom1504 rom1504 commented Dec 28, 2015

I guess DiegoRBaquero/BMagnet@5b9e389
@DiegoRBaquero

This comment has been minimized.

Sign in to view
Copy link
Member

@DiegoRBaquero DiegoRBaquero commented Dec 28, 2015

@feross Going to do that now.
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

@feross feross commented Dec 28, 2015

Make the changes or describe them? ;)
@DiegoRBaquero

This comment has been minimized.

Sign in to view
Copy link
Member

@DiegoRBaquero DiegoRBaquero commented Dec 28, 2015

@feross Make the changes and PR to the respective modules
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

@feross feross commented Dec 28, 2015

nice 👍
@DiegoRBaquero DiegoRBaquero mentioned this issue Dec 28, 2015
Merged
@DiegoRBaquero

This comment has been minimized.

Sign in to view
Copy link
Member

@DiegoRBaquero DiegoRBaquero commented Jan 29, 2016

@feross Any updates or changes that should be made? Maybe allow the users to selected through the opts the max size?
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

@feross feross commented Mar 1, 2016

This is released as 0.81.0. The web seed request size is now equal to the piece size, which is much better.
@feross feross closed this Mar 1, 2016
@lock

This comment has been minimized.

Sign in to view
Copy link

@lock lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.
@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement help wanted
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@hualiwang @rom1504 @DiegoRBaquero @feross
You can’t perform that action at this time.