Piece 0 requested infinite times

[DiegoRBaquero]

Using a webseeded small MP4 video file it gets downloaded over and over again.

'Set complete' is logged. Piece is neither verified or rejected

if (!piece.set(reservation, chunk, wire)) return onUpdateTick()

    debug('Set complete')

    var buf = piece.flush()

    // TODO: might need to set self.pieces[index] = null here since sha1 is async

    sha1(buf, function (hash) {
      if (hash === self._hashes[index]) {
        if (!self.pieces[index]) return
        debug('piece verified %s', index)

        self.pieces[index] = null
        self._reservations[index] = null
        self.bitfield.set(index, true)

        self.store.put(index, buf)

        self.swarm.wires.forEach(function (wire) {
          wire.have(index)
        })

        self._checkDone()
      } else {
        self.pieces[index] = new Piece(piece.length)
        self.emit('warning', new Error('Piece ' + index + ' failed verification'))
      }
      onUpdateTick()
    })

[feross]

That's odd.

1. Is this in node or the browser? What version?
2. Can you share a small code snippet that reproduces the issue?

[DiegoRBaquero]

@feross Latest version in the browser, now even using renderTo method.

The commented image does work fine.

html
    head
        title LiveTorrent
    body
        h1 Hello
        //img(bt-src="685dbb1b12f2d4ab747dd4e0f78e0bdf698aa112")
        video(bt-src="https://webseed.btorrent.xyz/small.mp4.torrent" controls autoplay)
        script(src="bundle2.js")

var client = require('webtorrent')()

elementList = document.querySelectorAll("[bt-src]")

//console.log(elementList)

for(var key in elementList) {
  var element = elementList[key]
  if(element && element.attributes && element.attributes['bt-src']) {
    var el = element
    var torrentId = element.attributes['bt-src'].nodeValue
    client.add(torrentId, function(torrent) {
      torrent.files[0].renderTo(el)
      /*torrent.files[0].getBlobURL(function(err, url) {
        el.src = url
      })*/
    })
  }

}

[feross]

There's a 99% chance this a bug in videostream. I just spoke with @jhiesey and he agrees. He's in the process of rewriting that package from scratch right now. Right now, it's heavily based on mp4box.js which is full of bugs and required significant hacking. I expect his new solution will work much better!

[DiegoRBaquero]

Adding video https://youtu.be/PPC8QMeu9Og

[feross]

@DiegoRBaquero Has this issue been fixed since the new videostream package came out? Does this also happen on instant.io? Can you email me the file, so I can try to reproduce this for myself?

[lock]

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.