Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all native dependencies #554

Closed
feross opened this issue Jan 3, 2016 · 5 comments
Closed

Remove all native dependencies #554

feross opened this issue Jan 3, 2016 · 5 comments
Labels
enhancement help wanted

Comments

@feross
Copy link
Member

@feross feross commented Jan 3, 2016

Native dependencies make webtorrent harder to install because you need to have a compiler toolchain installed. There are numerous issues on this issue tracker to attest to that.

Let's see if we can completely remove them.

Example issue about this: #457
@feross

This comment has been minimized.

Sign in to view
Copy link
Member Author

@feross feross commented Jan 3, 2016

Upgrading ws to 1.0.0 throughout the codebase will remove some native dependencies.
@feross

This comment has been minimized.

Sign in to view
Copy link
Member Author

@feross feross commented Jan 3, 2016

Nice, all ws is fully on 1.0.0 now. The last native dependency is:

> dtrace-provider@0.6.0 install /Users/feross/code/test/node_modules/webtorrent/node_modules/chromecasts/node_modules/node-ssdp/node_modules/bunyan/node_modules/dtrace-provider
@feross

This comment has been minimized.

Sign in to view
Copy link
Member Author

@feross feross commented Jan 4, 2016

Issue filed on node-ssdp: diversario/node-ssdp#47
@feross

This comment has been minimized.

Sign in to view
Copy link
Member Author

@feross feross commented Jan 6, 2016

node-ssdp removed it's native dependency! WebTorrent is now native dependency free!
@feross feross closed this Jan 6, 2016
@feross feross mentioned this issue Feb 11, 2016
Closed
@lock

This comment has been minimized.

Sign in to view
Copy link

@lock lock bot commented May 5, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement help wanted
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@feross
You can’t perform that action at this time.