Only show used candidates on https://webtorrent.io/

[KaptenJansson]

Currently https://webtorrent.io/ shows local host candidates with private IP addresses which I will never be able to access which indicates it displays the "first" (or some other type of selection) candidates seen.

Instead it should show reachable candidates that are actually used instead.

[DiegoRBaquero]

The private IPs are actually connected wires which transfer data to you. If not private, they are peers using public IPs.

[KaptenJansson]

Well ofc they are sending data, however it does not make sense showing host candidates that I can never connect to directly to (no one else on this network is visiting that page besides it displays private IP's on different subnets) thus the demo is not correctly conveying which endpoint I have established a peerconnection to.

[DiegoRBaquero]

Those are not candidates, else there would be more than 30 instantly. The shown peers are connected peers, not candidates.

On Jan 19, 2016, at 11:52 AM, Christoffer Jansson notifications@github.com wrote:

Well ofc they are sending data, however it does not make sense showing host candidates that I can never connect to directly thus the demo is not correctly conveying which endpoint I have established a peerconnection to.

—
Reply to this email directly or view it on GitHub.

[KaptenJansson]

Right, what I meant is that I cannot possibly connect to private IP's from my network (unless they are on my network) hence it looks like there something wrong with demo. As you mentioned, they are connected peers hence it makes sense displaying the IP address that I'm actually connected to.

It looks like you are using "any" candidate as a peer identifier in the demo rather than the actual connected IP address.

Does that make sense?

[feross]

@KaptenJansson Thanks for opening this issue. You are correct. Sometimes local IP address candidates are mistakenly shown on https://webtorrent.io. This is a bug in simple-peer.

I was able to fix this bug in Chrome, but it still exists in Firefox, as you can see here: feross/simple-peer#63

If you're interested, please contribute a fix!

(I'm going to close this issue here, since it's already being tracked on the simple-peer repo.)

[feross]

This is fixed now! Released in simple-peer 5.12.0.

[KaptenJansson]

Good stuff ;) When will it be pushed to webtorrent.io?

[feross]

It's published to webtorrent.io now.

[KaptenJansson]

Just tested it and now I just see public-ally accessible IP addresses, awesome!

[feross]

@KaptenJansson thanks!

[lock]

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.