Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use readable-stream throughout #593

Closed
feross opened this issue Feb 3, 2016 · 2 comments
Closed

Use readable-stream throughout #593

feross opened this issue Feb 3, 2016 · 2 comments

Comments

@feross
Copy link
Member

@feross feross commented Feb 3, 2016

feross added a commit that referenced this issue Feb 7, 2016
Use readable-stream to address #593
feross added a commit to feross/chunk-store-stream that referenced this issue Feb 28, 2016
feross added a commit to webtorrent/create-torrent that referenced this issue Feb 28, 2016
@feross

This comment has been minimized.

Copy link
Member Author

@feross feross commented Feb 28, 2016

This is all done in all the webtorrent packages, @mafintosh.

I still see require('stream') in stream-http which is what browserify uses for require('http'). But I think if the user's doing require('http') they're going to get whatever http their environment gives them, so it's probably fine not to worry about the version of stream being determined by the environment. In other words, you'll have the same issue with potentially getting back an unexpected version of the stream implementation if you do require('http') in node.

@feross feross closed this Feb 28, 2016
@lock

This comment has been minimized.

Copy link

@lock lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.

@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.