Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify webtorrent fixture files into one npm package #597

Closed
feross opened this issue Feb 5, 2016 · 5 comments
Closed

Unify webtorrent fixture files into one npm package #597

feross opened this issue Feb 5, 2016 · 5 comments

Comments

@feross
Copy link
Member

@feross feross commented Feb 5, 2016

Right now, sample .torrent files appear haphazardly in the various webtorrent packages for testing purposes. Mainly, Leaves of Grass. Let's just make a single package webtorrent-fixtures or something like that and make everything dev-depend on that.

  • webtorrent
  • parse-torrent
  • parse-torrent-file
  • bittorrent-tracker
  • ut_metadata
  • create-torrent
@feross

This comment has been minimized.

Copy link
Member Author

@feross feross commented Feb 28, 2016

@feross feross added the test label Mar 8, 2016
@rom1504

This comment has been minimized.

Copy link
Member

@rom1504 rom1504 commented Mar 14, 2016

webtorrent/parse-torrent-file#7 should be enough for parse-torrent-file.

@rom1504

This comment has been minimized.

Copy link
Member

@rom1504 rom1504 commented Mar 14, 2016

I want to do the 2 remaining packages, but waiting for feedback on webtorrent/parse-torrent-file#7 before starting.

@feross

This comment has been minimized.

Copy link
Member Author

@feross feross commented Mar 16, 2016

@rom1504 Thanks for offering to complete the other two packages, but I just went ahead and made the changes to prevent confusion. Much appreciated!

@feross feross closed this Mar 16, 2016
@lock

This comment has been minimized.

Copy link

@lock lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.

@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.