New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught exceptions in browsers without webrtc support #614

Closed
feross opened this Issue Feb 12, 2016 · 2 comments

Comments

2 participants
@feross
Member

feross commented Feb 12, 2016

There's an "Error: No WebRTC support: Not a supported browser" exception in Safari.

Visible on https://webtorrent.io. We can handle this more gracefully, which has the excellent side benefit of making torrent with web seeds (http fallback) continue to work just fine.

This would make WebTorrent more viable for use cases like relieving the server load for sites like https://glittering.blue/

@gverni

This comment has been minimized.

gverni commented Jan 15, 2018

Hi @feross,

I started working on this bug, but I found out that as of version 11 Safari is supporting WebRTC. I don't get anymore the "No WebRTC" support, but i'm getting some different exceptions now:

[Error] Unhandled Promise Rejection: [object DOMError]
(anonymous function)
rejectPromise
n (webtorrent.min.js:1:116340)
r (webtorrent.min.js:1:189815)
l (webtorrent.min.js:1:190266)
[Error] Unhandled Promise Rejection: NotSupportedError (DOM Exception 9): The operation is not supported.
(anonymous function)
rejectPromise
play
s (webtorrent.min.js:1:189293)
[Error] Unhandled Promise Rejection: [object DOMError]
(anonymous function)
rejectPromise

The video gets loaded, but it gets played only at the end of the download.

If you want I can work on those other exceptions instead. I haven't found them in any other bugs, so i'm not sure if someone is already working on them.

Giuseppe

@feross feross added accepted and removed accepted labels May 3, 2018

@feross

This comment has been minimized.

Member

feross commented May 16, 2018

@gverni Thanks for looking into this. Sorry for the delay in getting back to you about it.

Safari 11 on macOS does indeed support WebRTC, so this error should not be encountered by most users anymore.

Also, the promise rejection and the delayed video playback are also fixed now, thanks to work by @jhiesey on videostream.

I'm going to close this issue now :)

@feross feross closed this May 16, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Aug 14, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.