Join GitHub today
Uncaught exceptions in browsers without webrtc support #614
There's an "Error: No WebRTC support: Not a supported browser" exception in Safari.
Visible on https://webtorrent.io. We can handle this more gracefully, which has the excellent side benefit of making torrent with web seeds (http fallback) continue to work just fine.
This would make WebTorrent more viable for use cases like relieving the server load for sites like https://glittering.blue/
I started working on this bug, but I found out that as of version 11 Safari is supporting WebRTC. I don't get anymore the "No WebRTC" support, but i'm getting some different exceptions now:
[Error] Unhandled Promise Rejection: [object DOMError]
The video gets loaded, but it gets played only at the end of the download.
If you want I can work on those other exceptions instead. I haven't found them in any other bugs, so i'm not sure if someone is already working on them.
@gverni Thanks for looking into this. Sorry for the delay in getting back to you about it.
Safari 11 on macOS does indeed support WebRTC, so this error should not be encountered by most users anymore.
Also, the promise rejection and the delayed video playback are also fixed now, thanks to work by @jhiesey on
I'm going to close this issue now :)