Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tracker options into `opts.tracker` #649

Closed
feross opened this issue Mar 1, 2016 · 3 comments
Closed

Move tracker options into `opts.tracker` #649

feross opened this issue Mar 1, 2016 · 3 comments
Milestone
v1

Comments

@feross
Copy link
Member

@feross feross commented Mar 1, 2016

This will help to control the explosion of options in the WebTorrent API.

I already made the same change to torrent-discovery here: webtorrent/torrent-discovery@eb45af0
@feross feross added this to the Alpha milestone Mar 1, 2016
@nkittsteiner

This comment has been minimized.

Sign in to view
Copy link

@nkittsteiner nkittsteiner commented May 2, 2016

Can I have a look at this? Is still required?
@feross

This comment has been minimized.

Sign in to view
Copy link
Member Author

@feross feross commented May 2, 2016

Yes.
feross added a commit that referenced this issue May 8, 2016
@feross
Move tracker options into `opts.tracker`
Loading status checks…
47d181f 
Closes #649

Based on a PR by @nkittsteiner. #791
@feross feross mentioned this issue May 8, 2016
Merged
@feross feross closed this in #793 May 8, 2016
@lock

This comment has been minimized.

Sign in to view
Copy link

@lock lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.
@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
  v1
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@feross @nkittsteiner
You can’t perform that action at this time.