Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving webtorrent CLI to its own package #653

Closed
feross opened this issue Mar 2, 2016 · 3 comments
Closed

Consider moving webtorrent CLI to its own package #653

feross opened this issue Mar 2, 2016 · 3 comments

Comments

@feross
Copy link
Member

@feross feross commented Mar 2, 2016

This would let us remove lots of dependencies that are only used in the CLI.

@rom1504

This comment has been minimized.

Copy link
Member

@rom1504 rom1504 commented Mar 2, 2016

Sounds good but then cli users would have to npm install -g webtorrent-cli (and then use webtorrent-cli in the command line) ? Not sure how much of a problem that would be. It's certainly a breaking change though.

rom1504 added a commit to rom1504/webtorrent that referenced this issue Mar 3, 2016
@feross feross closed this in #667 Mar 11, 2016
@feross

This comment has been minimized.

Copy link
Member Author

@feross feross commented Mar 11, 2016

Released as 0.85.0.

@qgustavor qgustavor mentioned this issue Jan 7, 2017
8 of 12 tasks complete
@lock

This comment has been minimized.

Copy link

@lock lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.

@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.