Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ratelimit tracker connection attempts #659

Closed
dcposch opened this issue Mar 8, 2016 · 6 comments
Closed

Ratelimit tracker connection attempts #659

dcposch opened this issue Mar 8, 2016 · 6 comments

Comments

@dcposch
Copy link
Contributor

@dcposch dcposch commented Mar 8, 2016

  • WebTorrent version: 0.82.1
  • Node.js version: v4.2.4
  • Browser name/version (if using WebTorrent in the browser): Electron 0.36

If a tracker is down, we shouldn't keep trying to connect to it:

image
@dcposch

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

@dcposch dcposch commented Mar 8, 2016

When a tracker connection fails, we could mark that tracker as down and not try again for say 10 minutes
@DiegoRBaquero

This comment has been minimized.

Sign in to view
Copy link
Member

@DiegoRBaquero DiegoRBaquero commented Mar 11, 2016

I liked @dcposch 's idea. Will look into it now and PR
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

@feross feross commented Mar 11, 2016

We need to be careful here. If the user's internet connection is down for a minute, we don't want to block tracker connections for 10 minutes.
@DiegoRBaquero DiegoRBaquero mentioned this issue Mar 11, 2016
Merged
@DiegoRBaquero

This comment has been minimized.

Sign in to view
Copy link
Member

@DiegoRBaquero DiegoRBaquero commented Mar 11, 2016

@feross I opened a PR that will increase the time to reconnect on each retry. I removed the variance and set the initital at 15 seconds. Each retry adds 30 seconds.
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

@feross feross commented Mar 16, 2016

@dcposch FYI, this is fixed now.
@lock

This comment has been minimized.

Sign in to view
Copy link

@lock lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.
@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@dcposch @DiegoRBaquero @feross
You can’t perform that action at this time.