Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebTorrent v1.0.0 #668

Open
feross opened this issue Mar 12, 2016 · 7 comments
Open

WebTorrent v1.0.0 #668

feross opened this issue Mar 12, 2016 · 7 comments
Labels
Milestone

Comments

@feross
Copy link
Member

@feross feross commented Mar 12, 2016

Here's what I think WebTorrent needs to be v1.0.0.

  • Published spec for the WebTorrent protocol (BEP) #168
    • This is currently preventing adoption by other clients
  • CPU leak is causing Instant.io and WebTorrent.app to lag the kernel after ~10 minutes #551
    • This currently preventing real-world, long-term usage of WebTorrent
  • Release simple desktop application
    • This is currently preventing users from easily seeding torrents over the long-term
    • This is currently preventing web peers from having lots of potential peers
@feross feross added this to the v1 milestone Mar 12, 2016
@wI2L

This comment has been minimized.

Copy link

@wI2L wI2L commented Mar 30, 2016

Looking forward to the WebTorrent protocol BEP.

@dcposch

This comment has been minimized.

Copy link
Contributor

@dcposch dcposch commented Sep 20, 2016

Some more WebTorrent 1.0 ideas:

  • TrackerSocket refactor. Might fix #922
  • Enforce max numbers of WebRTC peers, BitTorrent peers, and web seeds allowed at a time. I think this will help performance when torrenting many files at once or files.

We probably also want to enforce that every torrent consist of a single file or folder. That would let us refactor the name, path, and files properties. Currently, when we want to delete data associated with a torrent, or implement Show In Finder, we have to resort to hacks.

@feross

@disarticulate

This comment has been minimized.

Copy link

@disarticulate disarticulate commented Oct 26, 2017

My trip through the source code didn't reveal to me where the issue is occuring, but it is definitely related to the pieceLength, which means the pieces aren't being GC'd or they're being duplicated.

@stale stale bot added the stale label May 3, 2018
@feross

This comment has been minimized.

Copy link
Member Author

@feross feross commented May 4, 2018

We're current at an insanely large minor version number — 0.99.4 — and we need to release 1.0.0 soon.

If we release another minor version – 0.100.0 — then the way that we calculate the version string in the wire protocol will roll over and cause problems. We only have two digits for the minor version!

@stale stale bot removed the stale label May 4, 2018
@disarticulate

This comment has been minimized.

Copy link

@disarticulate disarticulate commented May 4, 2018

what happens if you use the version number 💯

@webtorrent webtorrent deleted a comment from stale bot May 5, 2018
@feross

This comment has been minimized.

Copy link
Member Author

@feross feross commented May 5, 2018

The version part of the client ID will become 00100 which is a problem because it's supposed to only be 4 digits. For example, the current ID is 0099.

@stale

This comment has been minimized.

Copy link

@stale stale bot commented Aug 3, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Aug 3, 2018
@stale stale bot closed this Aug 10, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 8, 2018
@webtorrent webtorrent unlocked this conversation Aug 9, 2019
@feross feross reopened this Aug 9, 2019
@stale stale bot removed the stale label Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.