Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upWebTorrent v1.0.0 #668
WebTorrent v1.0.0 #668
Comments
This comment has been minimized.
This comment has been minimized.
|
Looking forward to the WebTorrent protocol BEP. |
This comment has been minimized.
This comment has been minimized.
|
Some more WebTorrent 1.0 ideas:
We probably also want to enforce that every torrent consist of a single file or folder. That would let us refactor the |
This comment has been minimized.
This comment has been minimized.
My trip through the source code didn't reveal to me where the issue is occuring, but it is definitely related to the pieceLength, which means the pieces aren't being GC'd or they're being duplicated. |
This comment has been minimized.
This comment has been minimized.
|
We're current at an insanely large minor version number — 0.99.4 — and we need to release 1.0.0 soon. If we release another minor version – 0.100.0 — then the way that we calculate the version string in the wire protocol will roll over and cause problems. We only have two digits for the minor version! |
This comment has been minimized.
This comment has been minimized.
|
what happens if you use the version number |
This comment has been minimized.
This comment has been minimized.
|
The version part of the client ID will become |
This comment has been minimized.
This comment has been minimized.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Here's what I think WebTorrent needs to be v1.0.0.