Add websocket trackers directly in webtorrent

[rom1504]

websocket trackers are added to existing torrents in all the webtorrent dependencies that support webrtc:

• webtorrent-hybrid
• instant.io
• webtorrent-app

It would probably make sense to put that directly in webtorrent, if there is webrtc support.

Also see that discussion webtorrent/webtorrent-hybrid#22 (comment)

[rom1504]

That global is handled in torrent.js

WebRtc support is available through simple-peer

[DiegoRBaquero]

WebRTC Support is also available on the client. No need to require simple-peer :)

[rom1504]

@DiegoRBaquero what do you mean by "the client" exactly ? Is .WEBRTC_SUPPORT available anywhere else ?

[DiegoRBaquero]

@rom1504 https://github.com/feross/webtorrent/blob/master/index.js#L21

[rom1504]

Yes but I can't require the index.js from torrent.js, see #673

[DiegoRBaquero]

You don't need to require it, a Torrent has the reference to the client. You can move the code to the constructor.

[rom1504]

Well it's all global anyway, I could put it anywhere. But I think it belongs to torrent.js since that's where it's used.

[DiegoRBaquero]

But, and anyone correct me if I'm wrong, wouldn't it be better inside the constructor after this line? torrent.js#L76

[feross]

It would probably make sense to put that directly in webtorrent, if there is webrtc support.

It's actually not a very good idea to make the webtorrent library automatically connect to third party servers without user consent. Because automatically adding servers to .torrent files is basically doing that. I actually made a change very recently to remove the behavior of adding trackers by default to added torrents here: bc69413

Instant.io is a file sending service, so it's fine for it to add it's own and other trackers by default.

WebTorrent.app and webtorrent-hybrid should probably stop adding trackers to added files as well (client.add). When the user wants to seed files (client.seed), on the other hand, I think it's fine to use some reasonable defaults when the user doesn't specify their own trackers.

Going forward, it's safest to ensure that magnet links or .torrent files explicitly contain the trackers to be used. client.seed and create-torrent will continue to do the right thing, so this shouldn't be very hard.

[rom1504]

I agree.
However we got to keep in mind that means if you download a (not created with webtorrent) torrent with webtorrent-app, it won't be made available to instant.io.

[lock]

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.