Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web seed support for multi-file torrents #684

Closed
dcposch opened this issue Mar 21, 2016 · 8 comments
Closed

Web seed support for multi-file torrents #684

dcposch opened this issue Mar 21, 2016 · 8 comments

Comments

@dcposch
Copy link
Contributor

@dcposch dcposch commented Mar 21, 2016

Currently, web seeds only work for single file torrents. If we fix that, then WebTorrent will be able to download torrents like this one:

http://www.archive.org/download/alls_well_that_ends_well_2_1603_librivox/alls_well_that_ends_well_2_1603_librivox_archive.torrent

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Mar 21, 2016

Confirmed.

@DiegoRBaquero

This comment has been minimized.

Copy link
Member

@DiegoRBaquero DiegoRBaquero commented Mar 21, 2016

Is there a spec? I was thinking (for multi-file torrents)... For any given piece being downloaded from a webseed, pass the file that it belongs to to the swarm's webconn peer and append it to the url of the webseed.

@yciabaud

This comment has been minimized.

Copy link
Contributor

@yciabaud yciabaud commented Mar 21, 2016

You're right according to the BEP0019 :

BitTorrent clients normally use the "name" from the torrent info section to make a folder, then use the "path/file" items from the info section within that folder. For the case of Multi-File torrents, the "url-list" must be a root folder where a client could add the same "name" and "path/file" to create the URL for the request.

For example:
... 8:url-list22:http://mirror.com/pub/ 4:infod5:filesld6:lengthi949e4:pathl10:Readme.txte e4:name7:michael

A client would use all that to build a url: http://mirror.com/pub/michael/Readme.txt

@yciabaud

This comment has been minimized.

Copy link
Contributor

@yciabaud yciabaud commented Mar 21, 2016

Notice the name of the torrent is appended to the root URL too.

@dcposch

This comment has been minimized.

Copy link
Contributor Author

@dcposch dcposch commented Mar 23, 2016

PR coming soon

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Mar 23, 2016

Merged Daniel's PR (https://github.com/feross/bittorrent-swarm/pull/33) with some fixes (https://github.com/feross/bittorrent-swarm/commit/247c79a1be5029654b03ad022e56124eea481eb0).

Still need to handle requests that span multiple files better.

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Mar 28, 2016

As of @dcposch's most recent PR (https://github.com/feross/bittorrent-swarm/pull/34), multi-file web seeding should be working correctly. Please open a new issue if this is not the case.

@feross feross closed this Mar 28, 2016
@lock

This comment has been minimized.

Copy link

@lock lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.

@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.