Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upElectron: verification should be faster #716
Comments
This comment has been minimized.
This comment has been minimized.
|
I just learned that So it seems like merely making Electron use I tried making a worker pool, but it's slowed down by the size of data that needs to be sent to each worker and didn't work reliably with torrents that had really large (~8MB) piece sizes. Too bad IPC calls don't work more like WebWorkers which support instantly transferring binary data to a worker (transferrable objects). The need for this is obviated (at least for webtorrent-desktop) by this PR: #715 |
This comment has been minimized.
This comment has been minimized.
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
Prompted by this comment by @dcposch: 664eb30#commitcomment-16936882
simple-sha1uses async methods to do hashing off the main thread (in browsers that support it). So, using the number of cores actually makes a lot of sense. Support list: http://caniuse.com/#feat=cryptographyThis is not working correctly in Electron because Electron ignores the "browser" field in
package.json.Current time to verify an 8GB test torrent on two separate runs:
52089.942ms
58375.643ms