Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External players like VLC #728

Closed
diimdeep opened this issue Apr 7, 2016 · 5 comments
Closed

External players like VLC #728

diimdeep opened this issue Apr 7, 2016 · 5 comments

Comments

@diimdeep
Copy link

@diimdeep diimdeep commented Apr 7, 2016

Until media playback will be feature rich, with subtitles, audio track selection etc., might be good to support external players.
Although manual open file in VLC works just fine.
Might help https://github.com/mafintosh/peerflix/blob/master/app.js#L28

@rom1504

This comment has been minimized.

Copy link
Member

@rom1504 rom1504 commented Apr 7, 2016

it is already possible in https://github.com/feross/webtorrent-cli

Maybe you meant to open an issue in https://github.com/feross/webtorrent-desktop/issues

@feross looks like there is some confusion between webtorrent and webtorrent-desktop. Might be caused by webtorrent-desktop about only telling about webtorrent and not webtorrent-desktop

@diimdeep

This comment has been minimized.

Copy link
Author

@diimdeep diimdeep commented Apr 9, 2016

Wrong repo, my fail. Recreated webtorrent/webtorrent-desktop#368

@diimdeep diimdeep closed this Apr 9, 2016
@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Apr 11, 2016

@rom1504 I think the confusion might be due to the big green GitHub button on https://webtorrent.io/desktop. Will make it point to webtorrent-desktop when on the Desktop page.

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Apr 11, 2016

@rom1504 Fixed now.

@lock

This comment has been minimized.

Copy link

@lock lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.

@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.