Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebTorrent: `torrent.swarm` is deprecated. #765

Closed
hisener opened this issue Apr 23, 2016 · 3 comments
Closed

WebTorrent: `torrent.swarm` is deprecated. #765

hisener opened this issue Apr 23, 2016 · 3 comments

Comments

@hisener
Copy link

@hisener hisener commented Apr 23, 2016

  • WebTorrent version: 1.1.2 (webtorrent 0.91.0)
  • Node.js version: v5.11.0
  • Browser name/version (if using WebTorrent in the browser):

webtorrent-cli on npm 3.8.6 on Ubuntu 16.04 LTS

$ webtorrent --vlc magnet_uri

WebTorrent: `torrent.swarm` is deprecated. Use `torrent` directly instead.

UNEXPECTED ERROR: If this is a bug in WebTorrent, report it!
OPEN AN ISSUE: https://github.com/feross/webtorrent/issues

DEBUG INFO: webtorrent-cli 1.1.2, webtorrent 0.91.0, node v5.11.0, linux x64, exit 1
/usr/local/lib/node_modules/webtorrent-cli/bin/cmd.js:488
    var unchoked = torrent.swarm.wires.filter(function (wire) {
                                ^

TypeError: Cannot read property 'wires' of undefined
    at Timeout.draw [as _repeat] (/usr/local/lib/node_modules/webtorrent-cli/bin/cmd.js:488:33)
    at Timeout.wrapper [as _onTimeout] (timers.js:408:11)
    at Timer.unrefdHandle (timers.js:445:14)

Update:
I have deleted "swarm"s from cmd.js it works but when torrent finished this error appeared.

torrent downloaded successfully from 2/3 peers in 482s!

webtorrent is exiting...

UNEXPECTED ERROR: If this is a bug in WebTorrent, report it!
OPEN AN ISSUE: https://github.com/feross/webtorrent/issues

DEBUG INFO: webtorrent-cli 1.1.2, webtorrent 0.91.0, node v5.11.0, linux x64, exit 1
/usr/local/lib/node_modules/webtorrent-cli/node_modules/webtorrent/lib/torrent.js:1471
    if (self.discovery.tracker) self.discovery.tracker.complete()
                      ^

TypeError: Cannot read property 'tracker' of null
    at Torrent._checkDone (/usr/local/lib/node_modules/webtorrent-cli/node_modules/webtorrent/lib/torrent.js:1471:23)
    at /usr/local/lib/node_modules/webtorrent-cli/node_modules/webtorrent/lib/torrent.js:1423:14
    at /usr/local/lib/node_modules/webtorrent-cli/node_modules/simple-sha1/index.js:6:5
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)
@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Apr 24, 2016

Yes, thanks for the report. I forgot to merge the PR I sent to webtorrent-cli: webtorrent/webtorrent-cli#6

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Apr 24, 2016

Released as webtorrent-cli 1.1.3

@feross feross closed this Apr 24, 2016
@lock

This comment has been minimized.

Copy link

@lock lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.

@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.