Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on including webtorrent.min.js #771

Closed
Lunik opened this issue Apr 24, 2016 · 10 comments
Closed

Error on including webtorrent.min.js #771

Lunik opened this issue Apr 24, 2016 · 10 comments

Comments

@Lunik
Copy link
Contributor

@Lunik Lunik commented Apr 24, 2016

  • WebTorrent version:
    0.91.1
  • Node.js version:
  • Browser name/version (if using WebTorrent in the browser):
    Chrome 49.0.2623.112 (64-bit)

When I include webtorrent.min.js to my html, I get this error in the console:
Uncaught TypeError: Object prototype may only be an Object or null: undefined webtorrent.min.js:5

@patrick-othmer

This comment has been minimized.

Copy link

@patrick-othmer patrick-othmer commented Apr 24, 2016

Same issue here. Looks like build 0.91.1 is bugged. Works without a problem with version 0.91.0.

@chrisnharvey

This comment has been minimized.

Copy link

@chrisnharvey chrisnharvey commented Apr 25, 2016

Exact same issue for me.

@Tercus

This comment has been minimized.

Copy link
Contributor

@Tercus Tercus commented Apr 25, 2016

For others having issues: In the URL to include the webtorrent.min.js, you can just replace the "/latest/" with the version you want to include. The last version that worked for me was "/0.90.3/".

@waleeddogar

This comment has been minimized.

Copy link

@waleeddogar waleeddogar commented Apr 27, 2016

Thank you @Tercus. I just spent hours on figuring out why I was having this issue. @feross please make it clear in the docs and stuff because this can be a huge pain point. I would resolve the issue as well if you have time. Other than that, you have created something awesome. Great job!

@emschwartz

This comment has been minimized.

Copy link

@emschwartz emschwartz commented Apr 27, 2016

I'm also running into this problem, even using 0.90.3. I'm using a fork of instant.io that browserifies the dependencies and it was working fine a few days ago, but I've since removed and reinstalled the dependencies. My guess is that it's actually not a problem with webtorrent 0.91.1 but an issue with a dependency of webtorrent that changed and broke between when 0.90.3 and 0.91.1 were bundled.

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Apr 27, 2016

I will look into this tomorrow. Sorry for the delay.

On Thu, 28 Apr 2016 at 00:40 Evan Schwartz notifications@github.com wrote:

I'm also running into this problem, even using 0.90.3. I'm using a fork
of instant.io that browserifies the dependencies and it was working fine
a few days ago, but I've since removed and reinstalled the dependencies. My
guess is that it's actually not a problem with webtorrent 0.91.1 but an
issue with a dependency of webtorrent that changed and broke between when
0.90.3 and 0.91.1 were bundled.


You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#771 (comment)

@emschwartz

This comment has been minimized.

Copy link

@emschwartz emschwartz commented Apr 27, 2016

I'm trying to hunt down the issue now.

The function that's complaining is inherits(IncomingMessage, stream.Readable) from stream-http

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Apr 27, 2016

I've seen that error before, I believe this is the solution: jhiesey/stream-http#41

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Apr 28, 2016

Fix published as 0.91.2

@lock

This comment has been minimized.

Copy link

@lock lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.

@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants
You can’t perform that action at this time.