Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromecast support #78

Closed
luiseduardobrito opened this issue Aug 10, 2014 · 14 comments
Closed

Chromecast support #78

luiseduardobrito opened this issue Aug 10, 2014 · 14 comments

Comments

@luiseduardobrito
Copy link

@luiseduardobrito luiseduardobrito commented Aug 10, 2014

Is it possible?

@trevorstarick

This comment has been minimized.

Copy link

@trevorstarick trevorstarick commented Aug 10, 2014

Is the question about streaming too the Chromecast with an application and another device or just with webtorrent and the Chromecast. Both cases I assume would be possible but Google would have to allow apps to be stored and ran off of the Chromecast.

Chromecast API

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Aug 10, 2014

This should be straightforward to add since we already support airplay. There's already an npm module for chromecast streaming. https://npmjs.org/package/chromecast-js It looks like the API is the same as the airplay-js api. I can add this later tonight :)

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Aug 11, 2014

Looks like the chromecast-js library is a bit immature. Posted a list of issues: guerrerocarlos/chromecast-js#1 Once these are addressed, I'll add it to webtorrent.

@phated

This comment has been minimized.

Copy link

@phated phated commented Aug 11, 2014

If that module is immature, is the only reason it was chosen over https://www.npmjs.org/package/chromecast the API compatability with airplay-js? If effort is being put into yet-another-chromecast-library, I'd be happy to invest time on mine again. Hopefully this time they don't completely destroy 3rd-party interaction.

@guerrerocarlos

This comment has been minimized.

Copy link

@guerrerocarlos guerrerocarlos commented Aug 11, 2014

Hello *,

Indeed the module is very alpha, but working on it intensively in order to include Chromecast Support in TorrenTV, the module is focused not only in "API compatiblity" but mostly in node-webkit compilance, by removing gyp-compiled module dependencies.

By the way, there is an initiative to centralize "airplay-js API style" modules for media streaming in http://github.com/media-js in case you want to be part of it. I will be including Xbmc's Airplay (https://github.com/guerrerocarlos/node-airplay-xbmc/) and Chromecas-js in there, as well as airplay-js

@phated

This comment has been minimized.

Copy link

@phated phated commented Aug 11, 2014

@guerrerocarlos which parts are gyp-compiled?

@guerrerocarlos

This comment has been minimized.

Copy link

@guerrerocarlos guerrerocarlos commented Aug 11, 2014

none anymore, since @jaimees2 rewrote a big part of node-castv2 (http://github.com/thibauts/node-castv2/pull/#5) and the only thing left was to migrate from mdns to mdns-js

@thibauts

This comment has been minimized.

Copy link

@thibauts thibauts commented Aug 11, 2014

The gyp-compiled part was the protobuf module. @jamiees2 effectively rebound the client to a full-js protobuf module in this PR. The referenced repo is the raw protocol implementation. A complete client is available at https://github.com/thibauts/node-castv2-client with facilities to use the DefaultMediaReceiver included in the Chromecast (avoids registering a custom receiver).

The only gyp-compiled part left is the mDNS discovery process included in the exemple code I gave in the README. The module itself doesn't use it. Though it could be easily replaced by a full-js module. The reason I suggested using the gyp-compiled mdns module is because it seems to play better with Avahi and other OS-provided mDNS daemons (it binds directly to them). In some cases using a a full-js mDNS client may make sense, but I'm not sure about the stability of this setup. Let me know if I can help.

@guerrerocarlos

This comment has been minimized.

Copy link

@guerrerocarlos guerrerocarlos commented Aug 11, 2014

@feross you can now try chromecast-js again and check if it's stable enough for you to use.

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Aug 14, 2014

Native modules are a no-go because they make life difficult for windows users. We've managed to avoid native modules so far and I'd like to keep it that way if possible!

I pushed a branch that adds chromecast support (https://github.com/feross/webtorrent/tree/chromecast) but I can't test it right now because my wifi router keeps crapping out. If someone who has a chromecast could test it, that would be great! Just use the --chromecast flag.

@luiseduardobrito

This comment has been minimized.

Copy link
Author

@luiseduardobrito luiseduardobrito commented Aug 14, 2014

I'll test it and send you guys feedback!


Luis Eduardo Brito

Engenharia de Computação
Universidade Estadual de Campinas (Unicamp)

Tel: +55 (19) 983 656 062

Sent from Gmail for Android
Em 14/08/2014 00:07, "Feross Aboukhadijeh" notifications@github.com
escreveu:

Native modules are a no-go because they make life difficult for windows
users. We've managed to avoid native modules so far and I'd like to keep it
that way if possible!

I pushed a branch that adds chromecast support (
https://github.com/feross/webtorrent/tree/chromecast) but I can't test it
right now because my wifi router keeps crapping out. If someone who has a
chromecast could test it, that would be great! Just use the --chromecast
flag.


Reply to this email directly or view it on GitHub
#78 (comment).

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Aug 15, 2014

I just got a chance to test this tonight and it works. Support was landed in 4cac8a1 (webtorrent v0.3.2)

The only downside is that chromecast-js currently unintentionally includes a native module, but I expect that to get fixed soon. Issue opened here: thibauts/node-castv2#5

@feross feross closed this Aug 15, 2014
@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Aug 15, 2014

Use webtorrent <torrent> --chromecast to test this out. But playback is still a bit stuttery due to this unresolved issue: https://github.com/feross/bittorrent-client/issues/33

@lock

This comment has been minimized.

Copy link

@lock lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.

@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.