Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow deleting deselected files #806

Open
dcposch opened this issue May 17, 2016 · 10 comments
Open

Allow deleting deselected files #806

dcposch opened this issue May 17, 2016 · 10 comments
Labels
accepted enhancement

Comments

@dcposch
Copy link
Contributor

@dcposch dcposch commented May 17, 2016

Say a torrent contains 10 files of 1GB each, but you only want to download two of them. How do you save disk space by deleting the other eight?

Currently, you can choose which files WebTorrent will download, but (as far as I can tell) there's no way to prevent the library from creating and holding an open file descriptor for all 10 files on disk.

Just closing the file descriptor for deselected files might be enough. That allows users of the library to then delete the file themselves.
@dcposch

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

@dcposch dcposch commented May 17, 2016 •
edited

@feross the corresponding feature in WebTorrent Desktop would benefit from this
@dcposch dcposch mentioned this issue May 18, 2016
Merged
dcposch added a commit to webtorrent/webtorrent-desktop that referenced this issue May 18, 2016
@dcposch
Don't unlink deselected files
Loading status checks…
9ca03fd 
I still want to do that eventually, but needs to be supported in WebTorrent

See webtorrent/webtorrent#806
dcposch added a commit to webtorrent/webtorrent-desktop that referenced this issue May 18, 2016
@dcposch
Clean up addSubtitles
Loading status checks…
0d80b93 
* Fix comments from #529

* Don't unlink deselected files

  I still want to do that eventually, but needs to be supported in WebTorrent

  See webtorrent/webtorrent#806
dcposch added a commit to webtorrent/webtorrent-desktop that referenced this issue May 18, 2016
@dcposch
Clean up addSubtitles (#535)
Loading status checks…
bc33520 
* Fix comments from #529

* Don't unlink deselected files

  I still want to do that eventually, but needs to be supported in WebTorrent

  See webtorrent/webtorrent#806
mathiasvr pushed a commit to mathiasvr/webtorrent-desktop that referenced this issue May 26, 2016
@dcposch
Clean up addSubtitles (webtorrent#535)
7bd30f8 
* Fix comments from webtorrent#529

* Don't unlink deselected files

  I still want to do that eventually, but needs to be supported in WebTorrent

  See webtorrent/webtorrent#806
@Wingman4l7

This comment has been minimized.

Sign in to view
Copy link

@Wingman4l7 Wingman4l7 commented May 31, 2016

Deselect would have to be working, first: #164
@feross feross added the enhancement label Jun 14, 2016
@kireerik

This comment has been minimized.

Sign in to view
Copy link

@kireerik kireerik commented Nov 16, 2016

In the current version I have a related issue. Storage space for deselected files are allocated. Is this already fixed in the development version?
@kocoten1992

This comment has been minimized.

Sign in to view
Copy link
Contributor

@kocoten1992 kocoten1992 commented Jan 12, 2017

@kireerik , have you tried dcposch solution on 164? It'll allocate 0 on file size 👍
@kireerik

This comment has been minimized.

Sign in to view
Copy link

@kireerik kireerik commented Jan 12, 2017 •
edited

Hi @kocoten1992, I have tried something like that using WebTorrent Desktop and sometimes it works, sometimes not.

Also torrents are starting immediately and there is no option for not to start torrents automatically when I add a new one.

Currently I am not actively using WebTorrent Desktop because it produced irrelevantly high download statistics on the torrent site that I am using. Maybe because it usually checks downloaded files again and again on start. Is this another bug in WebTorrent Desktop?
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

@feross feross commented Jan 13, 2017

@kireerik Currently I am not actively using WebTorrent Desktop because it produced irrelevantly high download statistics on the torrent site that I am using. Maybe because it usually checks downloaded files again and again on start. Is this another bug in WebTorrent Desktop?

This bug might have been fixed in webtorrent by not sending the 'complete' event when we successfully reverify the torrent data, since it's only supposed to be sent once. This fix hasn't made it into a WebTorrent Desktop release yet, but it will shortly.
@kireerik

This comment has been minimized.

Sign in to view
Copy link

@kireerik kireerik commented Jan 13, 2017

I see, and thank you for the information!

Do you have a plan about releasing a new build for WebTorrent Desktop soon?
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

@feross feross commented Jan 18, 2017

Yes, there will be a new release soon.
@kireerik

This comment has been minimized.

Sign in to view
Copy link

@kireerik kireerik commented Feb 14, 2017

Now I have version 0.18.0 installed, but the previously described 3 issues still exist.
@kolya182

This comment has been minimized.

Sign in to view
Copy link

@kolya182 kolya182 commented Jul 30, 2017

Really need this functionality.
@feross feross added accepted and removed accepted labels May 3, 2018
@kireerik kireerik mentioned this issue May 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted enhancement
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
@dcposch @Wingman4l7 @kireerik @kocoten1992 @feross @kolya182
You can’t perform that action at this time.