Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many false positives when using blocklist #863

Closed
romaincointepas opened this issue Jul 15, 2016 · 4 comments
Closed

Many false positives when using blocklist #863

romaincointepas opened this issue Jul 15, 2016 · 4 comments

Comments

@romaincointepas
Copy link

@romaincointepas romaincointepas commented Jul 15, 2016

Getting many peers being blocked (blockedPeer event) even if blacklist doesn't include those peers IPs.

I did a manual check of the blocklist (trying to find IPs or containing ranges) and a test using PeerBlock while trying to ping those IPs and in both cases IPs were not there or blocked.

Note: I could also find IPs that were blocked (blockedPeer) that appeared in the blocklist and were blocked by Peerblock.

One can reproduce with the following IPs:

83.249.18.137
61.84.203.79
101.50.115.240
58.224.143.38

And this blocklist file:
https://gist.githubusercontent.com/anonymous/aeafadfc4af0606fb36a585dca0f92ff/raw/6eca1bd1f193023d0797cc694393c29f3417f016/gistfile1.txt

If this is indeed a bug, it is probably coming from the fisch0920/ip-set module, but as there doesn't seem to be any activity there I thought it would be better to create the issue here.


  • WebTorrent version: 0.95.2
@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Jul 27, 2016

@romaincointepas Can you produce a smaller test case? That blocklist contains a huge amount of IPs which makes it hard to confirm that the 4 IPs you listed are not included in the list.

@Atavic

This comment has been minimized.

Copy link

@Atavic Atavic commented Feb 24, 2017

That's IBlocklist Corporate List.

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Mar 8, 2017

I'm closing this issue because it's been a while without a response from the issue opener. It's not possible to debug this issue without additional information. If this is still an issue, please leave a comment or open a new issue.

@feross feross closed this Mar 8, 2017
@lock

This comment has been minimized.

Copy link

@lock lock bot commented May 3, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.

@lock lock bot locked as resolved and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.