Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choking peers loop #890

Closed
DiegoRBaquero opened this issue Aug 26, 2016 · 5 comments
Closed

Choking peers loop #890

DiegoRBaquero opened this issue Aug 26, 2016 · 5 comments
Labels

Comments

@DiegoRBaquero
Copy link
Member

@DiegoRBaquero DiegoRBaquero commented Aug 26, 2016

  • WebTorrent version: latest (0.96.4)
  • Browser name/version (if using WebTorrent in the browser): Chrome 52

Log

Choking peers like this should be removed.

@feross feross added the bug label Sep 15, 2016
@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Sep 15, 2016

I've seen this happen before as well.

The "peer is choking" message comes from bittorrent-protocol and it can happen for two reasons:

  1. We have a outstanding pieces requests to a peer, and the peer decides to choke us. So the requests all get canceled.
  2. We are trying to make a request to a peer that is choking us. This is not allowed and would cause the peer to disconnect from us for misbehaving, so it is prevented by bittorrent-protocol library.

I think we're probably seeing the second case here, since it's the same piece and offset that are being repeatedly requested. So this is likely a bug in webtorrent itself.

@feross feross added the help wanted label Sep 15, 2016
@gpetrov

This comment has been minimized.

Copy link
Contributor

@gpetrov gpetrov commented Nov 6, 2016

@feross yes we also observed choking hangs, see #963
it will be nice if this get solved or a better choke handling gets implemented so the download don't just hangs

@gpetrov

This comment has been minimized.

Copy link
Contributor

@gpetrov gpetrov commented Nov 6, 2016

web seeds shouldn't choke, added PR #972

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Jan 29, 2017

Fixed by #972

@feross feross closed this Jan 29, 2017
@lock

This comment has been minimized.

Copy link

@lock lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.

@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.