Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Subtitles #892

Closed
Azpidatziak opened this issue Aug 28, 2016 · 2 comments
Closed

Add Subtitles #892

Azpidatziak opened this issue Aug 28, 2016 · 2 comments

Comments

@Azpidatziak
Copy link

@Azpidatziak Azpidatziak commented Aug 28, 2016

Hi webtorrent,

I think that it's will be a great feature, if you can add external subs to playing movie or etc.
Thanks!!
@DiegoRBaquero

This comment has been minimized.

Sign in to view
Copy link
Member

@DiegoRBaquero DiegoRBaquero commented Aug 29, 2016

This is a webtorrent-desktop feature request.

About this...

@feross words (webtorrent/webtorrent-desktop#722 (comment)):

we're not going to add this feature to WebTorrent Desktop, because the legality of OpenSubtitles is not clear to us.

Once there's a plugin system, I suppose you could build this as a plugin. But it's not something that should be a part of WebTorrent Desktop core.

Closing this.
@lock

This comment has been minimized.

Sign in to view
Copy link

@lock lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.
@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@Azpidatziak @DiegoRBaquero
You can’t perform that action at this time.