Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ws:// seeding in nodejs support? #896

Closed
abans opened this issue Sep 4, 2016 · 7 comments
Closed

ws:// seeding in nodejs support? #896

abans opened this issue Sep 4, 2016 · 7 comments
Labels

Comments

@abans
Copy link

@abans abans commented Sep 4, 2016

  • WebTorrent version:0.96
  • Node.js version:6.3.0
  • Browser name/version (if using WebTorrent in the browser):Chrome 53

Can you please add websocket protocol supported in nodejs?
I hope seeding in nodejs, and use the browser to download.

@DiegoRBaquero

This comment has been minimized.

Copy link
Member

@DiegoRBaquero DiegoRBaquero commented Sep 4, 2016

I've been thinking of implementing this myself, would definitely be superior than webseeding.

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Sep 14, 2016

@abans You can use webtorrent-hybrid if you want to have WebTorrent in Node.js connect to WebRTC peers.

@DiegoRBaquero You must be discussing something different. Can you clarify?

@DiegoRBaquero

This comment has been minimized.

Copy link
Member

@DiegoRBaquero DiegoRBaquero commented Sep 15, 2016

@feross I think this is about client-server seeding, but instead of http(s) use ws(s) for seeding.

On Sep 14, 2016, at 6:42 PM, Feross Aboukhadijeh notifications@github.com wrote:

@abans You can use webtorrent-hybrid if you want to have WebTorrent in Node.js connect to WebRTC peers.

@DiegoRBaquero You must be discussing something different. Can you clarify?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Oct 6, 2016

@DiegoRBaquero Hey, this seems like a potentially cool idea. What do you think about writing up a spec for what this would look like and trying to get it approved as a BEP, then we can implement it.

Without a BEP, I don't think we should include it. Also, you might want to test a bit more first since web seeds are already really light weight IMO. They are just http requests, which are really efficient in node.js and the browser. With HTTP2, the HTTP requests become a lot more efficient like WebSockets (re-using the same connection). So, I'm not sure there's a need for this feature.

Once we improve our web seed implementation, performance should improve even more: #650

@feross feross closed this Oct 6, 2016
@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Oct 6, 2016

Closing for now.

@DiegoRBaquero

This comment has been minimized.

Copy link
Member

@DiegoRBaquero DiegoRBaquero commented Oct 7, 2016

@feross I investigated many ways to do this and the most efficient would require building a bittorrent-protocol compatible websocket wire. Just for the sake of having it, it is not worth it. HTTP2 can perform the job with the same, if not better, performance with the added security restriction of TLS. After many hours of trying to build a prototype I came to the conclusion that I wouldn't build it and nobody should, is a waste of dev time, plus the added documentation that it would require.

Webseeding is pretty established and we should focus on improving it instead of dedicating any work towards websocket seeding.

@abans If you need any help implementing HTTP2 I would kindly help you.

@lock

This comment has been minimized.

Copy link

@lock lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.

@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.