Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client.add(infoHash [in hex]) doesn't appear to work. #902

Open
mikeal opened this issue Sep 5, 2016 · 8 comments
Open

client.add(infoHash [in hex]) doesn't appear to work. #902

mikeal opened this issue Sep 5, 2016 · 8 comments
Labels

Comments

@mikeal
Copy link
Contributor

@mikeal mikeal commented Sep 5, 2016

  • WebTorrent version:
    latest as of today :)
  • Node.js version:
    6.x cause I'm a responsible developer :P
  • Browser name/version (if using WebTorrent in the browser):
    Chrome 53

The docs say client.add() will work with an infoHash hex but it's not working for me. I literally seed a file in one tab and try to get it in another and it can't load the metadata. If i swap that out for a magnet url it works great.

@alxhotel

This comment has been minimized.

Copy link
Member

@alxhotel alxhotel commented Sep 5, 2016

Have you set the torrent trackers ?

@mikeal

This comment has been minimized.

Copy link
Contributor Author

@mikeal mikeal commented Sep 6, 2016

nope. if seed() defaults to a few trackers why doesn't add() default to the same trackers when none are specified?

@alxhotel

This comment has been minimized.

Copy link
Member

@alxhotel alxhotel commented Sep 6, 2016

Check out this comment: #672 (comment)

@mikeal

This comment has been minimized.

Copy link
Contributor Author

@mikeal mikeal commented Sep 6, 2016

Oh interesting, thanks! :)

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Sep 15, 2016

@alxhotel Thanks for linking to the rationale for the decision.

@mikeal Do you think this decision is a bit confusing? Maybe we should keep parallel behavior between seed() and add() when it comes to omitting trackers?

Happy to reconsider the decision if you think it is confusing for new users.

@feross feross added the question label Sep 15, 2016
@mikeal

This comment has been minimized.

Copy link
Contributor Author

@mikeal mikeal commented Sep 16, 2016

@feross I think it is confusing for sure, having the same behavior, or possibly giving a warning when omitting any trackers, would clear it up. I get why not having default trackers is a good idea, I just think it would be good to be consistent.

@DiegoRBaquero

This comment has been minimized.

Copy link
Member

@DiegoRBaquero DiegoRBaquero commented Sep 16, 2016

@mikeal Did you specify at least 1 custom tracker? If not, then this is a bug, as it should add the default ones.

@deamme

This comment has been minimized.

Copy link

@deamme deamme commented Oct 11, 2016

@DiegoRBaquero I think it's a bug because it doesn't add the default ones when a tracker is not specified. It works great with magnetURI though.

EDIT:
After some more reading - I think this works as intended..
@feross I agree with @mikeal

@stale stale bot added the stale label May 3, 2018
@webtorrent webtorrent deleted a comment from stale bot May 4, 2018
@stale stale bot removed the stale label May 4, 2018
@stale stale bot removed the stale label May 4, 2018
@feross feross removed the question label May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.