Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upDeprioritize range when connection was closed before the end #905
Comments
This comment has been minimized.
This comment has been minimized.
|
This is a good idea, why did you close this @romaincointepas. Re-opening. |
This comment has been minimized.
This comment has been minimized.
|
@feross It was more of a question, and I (if I remember correctly) found out that the answer was "no" (when http request is canceled, everything that was prioritized because of this request is removed from the priority list). Can you confirm? |
This comment has been minimized.
This comment has been minimized.
|
Actually, you're right. This is already implemented: https://github.com/feross/webtorrent/blob/beda5162c573adbecf5d6777b6821ec451b46639/lib/file.js#L83-L86 |
This comment has been minimized.
This comment has been minimized.
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Example:
In that case, is the range 20001-40000 still having priority or, because webtorrent has detected that it's not needed anymore, was deprioritized (aka same priority as before that request)?