Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprioritize range when connection was closed before the end #905

Closed
romaincointepas opened this issue Sep 8, 2016 · 4 comments
Closed

Deprioritize range when connection was closed before the end #905

romaincointepas opened this issue Sep 8, 2016 · 4 comments

Comments

@romaincointepas
Copy link

@romaincointepas romaincointepas commented Sep 8, 2016

Example:

  • A client (usually a player) would request the webtorrent http server for range 10000-40000
  • The user would then seek before the above request was completed, aborting the request (only 10000-20000 was sent back when the request was aborted)

In that case, is the range 20001-40000 still having priority or, because webtorrent has detected that it's not needed anymore, was deprioritized (aka same priority as before that request)?

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Jan 18, 2017

This is a good idea, why did you close this @romaincointepas. Re-opening.

@feross feross reopened this Jan 18, 2017
@romaincointepas

This comment has been minimized.

Copy link
Author

@romaincointepas romaincointepas commented Jan 19, 2017

@feross It was more of a question, and I (if I remember correctly) found out that the answer was "no" (when http request is canceled, everything that was prioritized because of this request is removed from the priority list).

Can you confirm?

@feross

This comment has been minimized.

Copy link
Member

@feross feross commented Jan 19, 2017

@feross feross closed this Jan 19, 2017
@lock

This comment has been minimized.

Copy link

@lock lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.

@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.