Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: torrent is destroyed #922

Closed
feross opened this issue Sep 18, 2016 · 3 comments
Closed

Error: torrent is destroyed #922

feross opened this issue Sep 18, 2016 · 3 comments
Labels
bug
Milestone

Comments

@feross
Copy link
Member

@feross feross commented Sep 18, 2016

  • WebTorrent version: 0.97.0
  • Node.js version: Electron 1.3.5

More instances of the famous "Error: torrent is destroyed" error, even though we just fixed one in 0.97.0.

It's funny -- we could actually get rid of all these by just returning instead of throwing an exception, but throwing helps us find all these cases where we didn't do proper cleanup and stuff is still happening after the torrent is destroyed.

Processes: webtorrent, platforms: darwin linux win32, versions: pre-0.12 0.13.1 0.14.0 0.15.0
Error: torrent is destroyed
    at Torrent.critical (...\node_modules\webtorrent\lib\torrent.js:895:29)
    at FileStream._notify (...\node_modules\webtorrent\lib\file-stream.js:53:26)
    at FileStream._read (...\node_modules\webtorrent\lib\file-stream.js:45:8)
    at FileStream.Readable.read (...\node_modules\webtorrent\node_modules\readable-stream\lib\_stream_readable.js:361:10)
    at readableAddChunk (...\node_modules\webtorrent\node_modules\readable-stream\lib\_stream_readable.js:214:18)
    at FileStream.Readable.push (...\node_modules\webtorrent\node_modules\readable-stream\lib\_stream_readable.js:172:10)
    at ...\node_modules\webtorrent\lib\file-stream.js:78:10
    at ...\node_modules\fs-chunk-store\index.js:200:7
    at end (...\node_modules\run-parallel\index.js:16:15)
    at done (...\node_modules\run-parallel\index.js:20:10)
@feross feross added the bug label Sep 18, 2016
@dcposch dcposch mentioned this issue Sep 20, 2016
2 of 3 tasks complete
@dcposch dcposch added this to the v1 milestone Sep 20, 2016
@DiegoRBaquero

This comment has been minimized.

Copy link
Member

@DiegoRBaquero DiegoRBaquero commented Feb 3, 2017

Should have been fixed with 6d5ff7a

@feross

This comment has been minimized.

Copy link
Member Author

@feross feross commented Feb 3, 2017

Alright, let's close this. I'll keep an eye on the WebTorrent Desktop telemetry for v0.18.0 and re-open if this error is still present.

@feross feross closed this Feb 3, 2017
@lock

This comment has been minimized.

Copy link

@lock lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.

@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.