Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upError: torrent is destroyed #922
Closed
Comments
This comment has been minimized.
This comment has been minimized.
|
Should have been fixed with 6d5ff7a |
This comment has been minimized.
This comment has been minimized.
|
Alright, let's close this. I'll keep an eye on the WebTorrent Desktop telemetry for v0.18.0 and re-open if this error is still present. |
This comment has been minimized.
This comment has been minimized.
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
More instances of the famous "Error: torrent is destroyed" error, even though we just fixed one in 0.97.0.
It's funny -- we could actually get rid of all these by just returning instead of throwing an exception, but throwing helps us find all these cases where we didn't do proper cleanup and stuff is still happening after the torrent is destroyed.