Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upMultiple files doesn't work in Brave #965
Closed
Labels
Comments
This comment has been minimized.
This comment has been minimized.
|
(this can be reproduced using Brave against a local instance of https://github.com/feross/instant.io) |
This comment has been minimized.
This comment has been minimized.
|
Single files are also messed up in Brave because of the same or similar code. The filename and path encoded into the torrent are just the last character in the string :( |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I think this was fixed a while ago, but since Brave will not be using Electron going forward, I think that they'll get the same |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.

If you take multiple files and drag/drop them into the browser and send the list of files from
drag-droptowebtorrent.seedyou get this error:Digging into it a bit it looks like Brave has a property on each File object that Chrome doesn't, the
.pathproperty. The property also appears to be immutable, I've tried working around the issue by deleting it or setting it to null but nothing happens, it doesn't throw either though.Webtorrent does a bunch of mutation of the file object properties which all may not work in Brave right now. May want to migrate that code to use local variables instead of mutating the file object.