Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple files doesn't work in Brave #965

Closed
mikeal opened this issue Nov 1, 2016 · 4 comments
Closed

Multiple files doesn't work in Brave #965

mikeal opened this issue Nov 1, 2016 · 4 comments
Labels

Comments

@mikeal
Copy link
Contributor

@mikeal mikeal commented Nov 1, 2016

If you take multiple files and drag/drop them into the browser and send the list of files from drag-drop to webtorrent.seed you get this error:

Uncaught TypeError: item.path.shift is not a function

Digging into it a bit it looks like Brave has a property on each File object that Chrome doesn't, the .path property. The property also appears to be immutable, I've tried working around the issue by deleting it or setting it to null but nothing happens, it doesn't throw either though.

Webtorrent does a bunch of mutation of the file object properties which all may not work in Brave right now. May want to migrate that code to use local variables instead of mutating the file object.

  • WebTorrent version: 0.97.2
  • Node.js version: 6
  • Browser name/version (if using WebTorrent in the browser): Brave
@josephfrazier

This comment has been minimized.

Copy link
Member

@josephfrazier josephfrazier commented Nov 2, 2016

(this can be reproduced using Brave against a local instance of https://github.com/feross/instant.io)

@mikeal

This comment has been minimized.

Copy link
Contributor Author

@mikeal mikeal commented Nov 3, 2016

Single files are also messed up in Brave because of the same or similar code. The filename and path encoded into the torrent are just the last character in the string :(

@stale

This comment has been minimized.

Copy link

@stale stale bot commented May 3, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 3, 2018
@feross

This comment has been minimized.

Copy link
Member

@feross feross commented May 3, 2018

I think this was fixed a while ago, but since Brave will not be using Electron going forward, I think that they'll get the same File implementation as Chrome now so this should definitely work in Brave beta now. LMK if this is not the case.

@feross feross closed this May 3, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.