Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] fixed an emit bug and added bittorrent-tracker to bittorrent-client #99

Closed
feross opened this issue Sep 21, 2014 · 4 comments
Closed

Comments

@feross
Copy link
Member

@feross feross commented Sep 21, 2014

Issue by fisch0920
Wednesday May 07, 2014 at 06:18 GMT
Originally opened as https://github.com/feross/bittorrent-client/pull/3


fixed a bug where bittorrent-client should emit the torrent not itself on metadata; also added preliminary support for bittorrent-tracker to bittorrent-client


fisch0920 included the following code: https://github.com/feross/bittorrent-client/pull/3/commits

@feross

This comment has been minimized.

Copy link
Member Author

@feross feross commented Sep 21, 2014

Comment by fisch0920
Wednesday May 07, 2014 at 08:39 GMT


Also depends on important fix for bitfield here fb55/bitfield#10

@feross

This comment has been minimized.

Copy link
Member Author

@feross feross commented Sep 21, 2014

Comment by fisch0920
Wednesday May 07, 2014 at 08:45 GMT


After this set of changes and my other related pull requests, the bittorrent-client example finally works again :)

@feross

This comment has been minimized.

Copy link
Member Author

@feross feross commented Sep 21, 2014

Comment by feross
Wednesday May 07, 2014 at 19:56 GMT


Thank you for going through this and fixing things up! This module is a work-in-progress, so none of the code had been actually been tested before in this configuration before. Originally, it was part of a chrome app, but I think it's a lot nicer to have this as it's own module.

Hooray! Now the first test passes and a full file gets downloaded. 👍

Published as 0.0.2.

@feross

This comment has been minimized.

Copy link
Member Author

@feross feross commented Sep 21, 2014

Comment by fisch0920
Wednesday May 07, 2014 at 20:24 GMT


Awesome -- maybe we could chat offline about the status of things and where I could help out given that I don't want to step on your toes or duplicate work, and you could probably throw some reasonably scoped/isolated/prioritized work my way?

@lock lock bot locked as resolved and limited conversation to collaborators May 7, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.