Track tasks and feature requests
Join 40 million developers who use GitHub issues to help identify, assign, and keep track of the features and bug fixes your projects need.
Sign up for free See pricing for teams and enterprises[CLOSED] fixed an emit bug and added bittorrent-tracker to bittorrent-client #99
Comments
This comment has been minimized.
This comment has been minimized.
|
Also depends on important fix for bitfield here fb55/bitfield#10 |
This comment has been minimized.
This comment has been minimized.
|
After this set of changes and my other related pull requests, the bittorrent-client example finally works again :) |
This comment has been minimized.
This comment has been minimized.
|
Thank you for going through this and fixing things up! This module is a work-in-progress, so none of the code had been actually been tested before in this configuration before. Originally, it was part of a chrome app, but I think it's a lot nicer to have this as it's own module. Hooray! Now the first test passes and a full file gets downloaded. Published as 0.0.2. |
This comment has been minimized.
This comment has been minimized.
|
Awesome -- maybe we could chat offline about the status of things and where I could help out given that I don't want to step on your toes or duplicate work, and you could probably throw some reasonably scoped/isolated/prioritized work my way? |
Wednesday May 07, 2014 at 06:18 GMT
Originally opened as https://github.com/feross/bittorrent-client/pull/3
fixed a bug where bittorrent-client should emit the torrent not itself on metadata; also added preliminary support for bittorrent-tracker to bittorrent-client
fisch0920 included the following code: https://github.com/feross/bittorrent-client/pull/3/commits