Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdating electron-prebuilt to 1.4.13 #1045
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
|
This causes the Electron tests to freeze on Travis. I tried to debug this before, but I think it's a subtle bug in the zuul test runner. You can see how it froze here: https://travis-ci.org/feross/webtorrent/builds/201759142 I think we should keep this pinned for now. |
This comment has been minimized.
This comment has been minimized.
|
@DiegoRBaquero Btw, what is bithound? I see that in the branch name. |
This comment has been minimized.
This comment has been minimized.
|
@feross bithound does code analysis on repos, looks for security issues, dep issues, etc. It was it that suggested the upgrade. |
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
May 4, 2018
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
DiegoRBaquero commentedFeb 15, 2017
Please update electron-prebuilt to version 1.4.13.
If this passes your tests you can merge it in. If not please use this branch for changes.