Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for NAT traversal techniques #1051
Open
+193
−2
Conversation
This comment has been minimized.
This comment has been minimized.
|
Using my patch TooTallNate/node-nat-pmp#13 does the trick, we should wait for it to be merged but I have no feedback ATM. |
This comment has been minimized.
This comment has been minimized.
heroboy
commented
Jun 15, 2017
|
What protocol port you used to map? As I know dht uses UDP. |
This comment has been minimized.
This comment has been minimized.
stale
bot
commented
Sep 18, 2018
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
yciabaud commentedFeb 18, 2017
Here is an implementation of NAT traversal as discussed in #195 using https://github.com/indutny/node-nat-upnp and https://github.com/TooTallNate/node-nat-pmp.
I have also ecountered https://github.com/level451/pmp that claims to make both UPnP ad NAT-PMP but I don't have tested it.
This feature is implemented in a new module for node env only and provided by a single instance shared by the webtorrent clients because NAT-PMP needs to open a specific port to work.
I checked the UPnP part with my router by it does not support NAT-PMP protocol.
The mappings are sent both with UPnP and NAT-PMP whe available and refreshed every 30 min.
Reviews are welcome!