Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use random port #1053

Merged
merged 1 commit into from Feb 21, 2017
Merged

Use random port #1053

merged 1 commit into from Feb 21, 2017

Conversation

@DiegoRBaquero
Copy link
Member

DiegoRBaquero commented Feb 20, 2017

While running tests concurrently I sometimes receive warnings.

This allows a random port to be chosen.

Tests will pass.

@feross
feross approved these changes Feb 21, 2017
Copy link
Member

feross left a comment

LGTM

@feross feross merged commit 9ec8ad1 into master Feb 21, 2017
4 of 5 checks passed
4 of 5 checks passed
Node Security nsp check
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@feross feross deleted the random-port branch Feb 21, 2017
@lock

This comment has been minimized.

Copy link

lock bot commented May 3, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.

@lock lock bot locked as resolved and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.