Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make WTGC description more clear #1055

Merged
merged 1 commit into from Feb 21, 2017

Conversation

@FluorescentHallucinogen
Copy link
Contributor

FluorescentHallucinogen commented Feb 21, 2017

No description provided.

Copy link
Member

DiegoRBaquero left a comment

Why shorten the url through a 3rd part service?

If there's no valid reason, please keep the original link

@FluorescentHallucinogen

This comment has been minimized.

Copy link
Contributor Author

FluorescentHallucinogen commented Feb 21, 2017

Git.io is not a "3rd part service", it is official GitHub URL shortener. Many projects use it.

@DiegoRBaquero

This comment has been minimized.

Copy link
Member

DiegoRBaquero commented Feb 21, 2017

Ohhh, didn't know that. Well, can you keep to original to maintain consistency?

@FluorescentHallucinogen

This comment has been minimized.

Copy link
Contributor Author

FluorescentHallucinogen commented Feb 21, 2017

I want to use this short vanity git.io URL everywhere. Is it a problem? If yes, I can change it to full URL.

@DiegoRBaquero

This comment has been minimized.

Copy link
Member

DiegoRBaquero commented Feb 21, 2017

It's cool :)

@DiegoRBaquero DiegoRBaquero merged commit df94b55 into webtorrent:master Feb 21, 2017
3 checks passed
3 checks passed
Node Security No known vulnerabilities found
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@FluorescentHallucinogen

This comment has been minimized.

Copy link
Contributor Author

FluorescentHallucinogen commented Feb 22, 2017

@FluorescentHallucinogen

This comment has been minimized.

Copy link
Contributor Author

FluorescentHallucinogen commented Mar 17, 2017

@feross

This comment has been minimized.

Copy link
Member

feross commented Mar 17, 2017

@FluorescentHallucinogen That gets updated the next time the site is built. I'll kick off a build.

@lock

This comment has been minimized.

Copy link

lock bot commented May 3, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.

@lock lock bot locked as resolved and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.