Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bogota to run tests #1056

Closed
wants to merge 1 commit into from
Closed

Use bogota to run tests #1056

wants to merge 1 commit into from

Conversation

@DiegoRBaquero
Copy link
Member

DiegoRBaquero commented Feb 22, 2017

I created a tape test runner that runs tests concurrently. Source: https://github.com/DiegoRBaquero/bogota

Time results using gtime in my Mac:

tape:

# gtime tape test/node/*.js
1.73user 0.25system 0:04.50elapsed
1.72user 0.24system 0:04.47elapsed
1.77user 0.26system 0:04.54elapsed
1.84user 0.25system 0:04.62elapsed
1.65user 0.21system 0:04.26elapsed
1.70user 0.20system 0:04.28elapsed
1.64user 0.21system 0:04.24elapsed
1.69user 0.30system 0:04.61elapsed

bogota:

# gtime bogota test/node/*.js
5.06user 0.65system 0:03.36elapsed
5.26user 0.63system 0:02.70elapsed
5.13user 0.63system 0:03.80elapsed
5.29user 0.63system 0:02.90elapsed
4.98user 0.57system 0:03.28elapsed
4.66user 0.54system 0:03.46elapsed
4.92user 0.55system 0:03.14elapsed
4.66user 0.55system 0:03.13elapsed
@DiegoRBaquero

This comment has been minimized.

Copy link
Member Author

DiegoRBaquero commented Feb 22, 2017

Works perfectly local and push build passed. I'm wondering what is making it fail in the PR build

@feross

This comment has been minimized.

Copy link
Member

feross commented Mar 9, 2017

The tests appear to be about twice as slow with bogata as with tape. On my machine:

bogata

$ time npm run test-node
npm run test-node  5.47s user 0.73s system 65% cpu 9.416 total

tape

$ time npm run test-node
npm run test-node  2.52s user 0.34s system 50% cpu 5.698 total

You might want to look into that!

@feross

This comment has been minimized.

Copy link
Member

feross commented Mar 9, 2017

Also, frankly, since the tests take less than 6 seconds, I'm not sure this is actually a problem we need to solve.

@DiegoRBaquero DiegoRBaquero deleted the bogota-test-runner branch Apr 8, 2017
@lock

This comment has been minimized.

Copy link

lock bot commented May 3, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.