Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUse bogota to run tests #1056
Closed
Use bogota to run tests #1056
+2
−1
Conversation
This comment has been minimized.
This comment has been minimized.
|
Works perfectly local and push build passed. I'm wondering what is making it fail in the PR build |
This comment has been minimized.
This comment has been minimized.
|
The tests appear to be about twice as slow with bogata$ time npm run test-node
npm run test-node 5.47s user 0.73s system 65% cpu 9.416 totaltape$ time npm run test-node
npm run test-node 2.52s user 0.34s system 50% cpu 5.698 totalYou might want to look into that! |
This comment has been minimized.
This comment has been minimized.
|
Also, frankly, since the tests take less than 6 seconds, I'm not sure this is actually a problem we need to solve. |
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
May 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.

DiegoRBaquero commentedFeb 22, 2017
I created a tape test runner that runs tests concurrently. Source: https://github.com/DiegoRBaquero/bogota
Time results using gtime in my Mac:
tape:
# gtime tape test/node/*.js 1.73user 0.25system 0:04.50elapsed 1.72user 0.24system 0:04.47elapsed 1.77user 0.26system 0:04.54elapsed 1.84user 0.25system 0:04.62elapsed 1.65user 0.21system 0:04.26elapsed 1.70user 0.20system 0:04.28elapsed 1.64user 0.21system 0:04.24elapsed 1.69user 0.30system 0:04.61elapsedbogota:
# gtime bogota test/node/*.js 5.06user 0.65system 0:03.36elapsed 5.26user 0.63system 0:02.70elapsed 5.13user 0.63system 0:03.80elapsed 5.29user 0.63system 0:02.90elapsed 4.98user 0.57system 0:03.28elapsed 4.66user 0.54system 0:03.46elapsed 4.92user 0.55system 0:03.14elapsed 4.66user 0.55system 0:03.13elapsed