Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement correct interested behaviour #1061
Merged
+10
−3
Conversation
| if (self._amInterested) wire.interested() | ||
| var interested = false | ||
| for (var index = 0; index < self.pieces.length; ++index) { | ||
| if (self.pieces[index] && wire.peerPieces.get(index)) { |
This comment has been minimized.
This comment has been minimized.
DiegoRBaquero
May 24, 2017
Member
Shouldn't this !self.pieces[index]? Indicating that we don't yet have that piece?
This comment has been minimized.
This comment has been minimized.
KayleePop
May 16, 2018
Contributor
self.pieces[index] is deleted when that piece is downloaded and verified, so self.pieces[index] would be truthy when the piece still needs to be downloaded. The actual piece data is in the store. self.pieces[] is used to facilitate downloading.
!self.bitfield.get(index) is clearer.
|
LGTM |
This comment has been minimized.
This comment has been minimized.
welcome
bot
commented
Jul 25, 2018
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bradleyjkemp commentedFeb 25, 2017
Start peers as uninterested and only move to interested if/once they have a piece that we need
Fixes #1059