Implement correct interested behaviour #1061
+10
−3
| @@ -1095,7 +1095,7 @@ Torrent.prototype._onWireWithMetadata = function (wire) { | ||
| }) | ||
|
|
||
| wire.bitfield(self.bitfield) // always send bitfield (required) | ||
| wire.interested() // always start out interested | ||
| wire.uninterested() // always start out uninterested (as per protocol) | ||
|
|
||
| // Send PORT message to peers that support DHT | ||
| if (wire.peerExtensions.dht && self.client.dht && self.client.dht.listening) { | ||
| @@ -1174,8 +1174,15 @@ Torrent.prototype._updateInterest = function () { | ||
| self._amInterested = !!self._selections.length | ||
|
|
||
| self.wires.forEach(function (wire) { | ||
| // TODO: only call wire.interested if the wire has at least one piece we need | ||
| if (self._amInterested) wire.interested() | ||
| var interested = false | ||
| for (var index = 0; index < self.pieces.length; ++index) { | ||
| if (self.pieces[index] && wire.peerPieces.get(index)) { | ||
|
||
| interested = true | ||
| break | ||
| } | ||
| } | ||
|
|
||
| if (interested) wire.interested() | ||
| else wire.uninterested() | ||
| }) | ||
|
|
||
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Shouldn't this
!self.pieces[index]? Indicating that we don't yet have that piece?