Add local file deletion on `torrent.destroy`

[Rowern]

When we call torrent.destroy and we are not running in a browser, we use
rimraf to delete the folder containing the torrent files.

This is a work in progress because I need feedback on a good way to implement it.
For instance, client.destroy calls torrent.destroy on all its torrents, this might be problematic as destroying the client looks like the legitimate way of stopping every torrent transactions but keeping your progress.

[feross]

Thanks for the PR, @Rowern!

I think the right way to handle this is to call the destroy() method on the store, which already uses rimraf internally. See here: https://github.com/feross/fs-chunk-store/blob/8d7a57b56572625346024fca8cf3e2839ba2d49d/index.js#L222-L232

I haven't looked, but I suspect that we're only calling close() to close the store, but not destroy it.

You're right that we also want to keep the option to destroy the torrent without destroying the files on disk, so that probably should be an option to torrent.destroy(), like torrent.destroy({ remove: true }) which defaults to false.

[Rowern]

You are right, I will continue to work on this PR tomorrow.

[Rowern]

I know this might not work well with browser API, I might add a check on the type of store used.

[Rowern]

Sorry for closing/re-opening but it was the only way to re-trigger a travis build.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.