Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update faq.md #1126

Merged
merged 1 commit into from May 23, 2017
Merged

Update faq.md #1126

merged 1 commit into from May 23, 2017

Conversation

@manicphase
Copy link
Contributor

manicphase commented May 14, 2017

added super quick share

added super quick share
@DiegoRBaquero

This comment has been minimized.

Copy link
Member

DiegoRBaquero commented May 15, 2017

Hello @manicphase ! Thank you for sharing what you've created.

I had trouble getting to use it, however. I could not get to share an image.

It would be best if you could make the necessary changes to improve the user experience and make it more user friendly before we add the link.

@manicphase

This comment has been minimized.

Copy link
Contributor Author

manicphase commented May 16, 2017

Thanks for the feedback.

Could you tell me what you did and what went wrong? Like what devices/browsers you used. A console output if possible.

I know there's a couple of issues like iPhone compatibility, webtorrent trackers are blocked on corporate WiFi and that it's unable to transfer between ipv4 and ipv6, but I haven't had a problem otherwise. I should probably implement some error messages for that and some more obvious feedback for when it's working on something before requesting a pull again.

Thanks.

@manicphase

This comment has been minimized.

Copy link
Contributor Author

manicphase commented May 19, 2017

I think i might have fixed the bug. There was an issue with chrome where it would try to use scrollTo on an element that chrome doesn't allow but firefox does. This would cause it to throw an exception before creating the torrent. Is this working for you now?

Copy link
Contributor

yciabaud left a comment

The application is working now, I believe it can be merged.

Copy link
Member

DiegoRBaquero left a comment

Worked for me now :)

@DiegoRBaquero DiegoRBaquero merged commit 1a035e4 into webtorrent:master May 23, 2017
3 checks passed
3 checks passed
Node Security No known vulnerabilities found
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lock lock bot locked as resolved and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.