Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upswitch to ES6-compatible minifier #1148
Merged
Conversation
Some downstream dependencies have introduced ES6 (bencode@1.0.0) and there are others that have done so too, but which I've refrained from updating (junk@2.0.0). It's going to keep getting harder and harder to keep this code out of the codebase -- so let's use babili, which is a minifier that supports ES6. It compresses worse than uglify (I think the bundle is something like 3KB larger now), but it's worth it IMO.
|
I've been using |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
feross commentedJun 23, 2017
Some downstream dependencies have introduced ES6 (bencode@1.0.0) and
there are others that have done so too, but which I've refrained from
updating (junk@2.0.0).
It's going to keep getting harder and harder to keep this code out of
the codebase -- so let's use babili, which is a minifier that supports
ES6.
It compresses worse than uglify (I think the bundle is something like
3KB larger now), but it's worth it IMO.