Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upRaise error when streaming from a removed torrent #1166
Merged
Conversation
In Node.js 8.2.1, when a torrent is removed while a file from it is being streamed, file-stream.js exits, crashing Node with a TypeError: VM535 file-stream.js:64 Uncaught TypeError: Cannot read property 'get' of null This patch checks whether the torrent has been marked as destroyed, and if so, raises the error to the file stream.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aveday commentedJul 29, 2017
In Node.js 8.2.1, when a torrent is removed while a file from it is being
streamed, file-stream.js exits, crashing Node with a TypeError:
VM535 file-stream.js:64 Uncaught TypeError: Cannot read property 'get' of null
This patch checks whether the torrent has been marked as destroyed, and
if so, raises the error to the file stream.