Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error when streaming from a removed torrent #1166

Merged
merged 1 commit into from Sep 9, 2017
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Raise error when streaming from a removed torrent

In Node.js 8.2.1, when a torrent is removed while a file from it is being
 streamed, file-stream.js exits, crashing Node with a TypeError:

VM535 file-stream.js:64 Uncaught TypeError: Cannot read property 'get' of null

This patch checks whether the torrent has been marked as destroyed, and
 if so, raises the error to the file stream.
  • Loading branch information
David Chevers Williams
David Chevers Williams committed Jul 29, 2017
commit c04a4167250bfa236f78e91352867aa3c6c9c33f
@@ -56,6 +56,8 @@ FileStream.prototype._notify = function () {
if (self._notifying) return
self._notifying = true

if (self._torrent.destroyed) return self._destroy(new Error('Torrent removed'))

var p = self._piece
self._torrent.store.get(p, function (err, buffer) {
self._notifying = false
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.