Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate mime to the latest version 🚀 #1254
Closed
Conversation
|
mime.lookup was removed, we need to update our codebase before we can merge this. |
This comment has been minimized.
This comment has been minimized.
|
@DiegoRBaquero I took care of that and updated mime :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
greenkeeper bot commentedJan 4, 2018
Version 2.2.0 of mime was just published.
The version 2.2.0 is not covered by your current version range.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
It might be worth looking into these changes and trying to get this project onto the latest version of mime.
If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.
Commits
The new version differs by 48 commits ahead by 48, behind by 10.
797e9cechore(release): 2.2.010f82acfeat: Retain type->extension mappings for non-default types. Fixes #18010550a2chore(release): 2.1.03f775bafeat: Upgrade to mime-db@1.32.0. Fixes #18594b29d3chore(release): 2.0.57e1750efix: Use standard-version to build releasef14ccb6fix: ES5 support (back to node v0.4)ab5238a2.0.4b94c4abchangelog175cd7cmime-score -> dev dependency8cc0f4fRemove vestigial getScore() method852b042Merge branch 'master' of github.com:broofa/node-mimef548916use mime-score module for resolving extension contentions. Fixes #18234b5c6bLink to 1.x version of docs6e7b9bbMerge pull request #177 from JuanjoSalvador/patch-1There are 48 commits in total.
See the full diff
FAQ and help
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper bot🌴