Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hostname option to mitigate DNS rebinding #1260

Merged
merged 2 commits into from Mar 2, 2018
+8 −0
Merged

Add hostname option to mitigate DNS rebinding #1260

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eea73a3
Add hostname option to mitigate DNS rebinding
diracdeltas Jan 12, 2018
7c107e6
simplify double if statement
feross Mar 2, 2018
File filter...
Filter file types
Clear filters
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Prev
Loading status checks…

simplify double if statement

  • Loading branch information
@feross
feross committed Mar 2, 2018
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
commit 7c107e6d47415d72ca7fd075fc8f78aaae548908
6 lib/server.js
View file
Open in desktop
@@ -54,10 +54,8 @@ function Server (torrent, opts) {
// If a 'hostname' string is specified, deny requests with a 'Host'
// header that does not match the origin of the torrent server to prevent
// DNS rebinding attacks.
if (opts.hostname) {
if (req.headers.host !== `${opts.hostname}:${server.address().port}`) {
return false
}
if (opts.hostname && req.headers.host !== `${opts.hostname}:${server.address().port}`) {
return false
}

// The user allowed all origins
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.