Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hostname option to mitigate DNS rebinding #1260

Merged
merged 2 commits into from Mar 2, 2018
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -327,6 +327,7 @@ Returns an `http.Server` instance (got from calling `http.createServer`). If
```js
{
origin: String // Allow requests from specific origin. `false` for same-origin. [default: '*']
hostname: String // If specified, only allow requests whose `Host` header matches this hostname. Note that you should not specify the port since this is automatically determined by the server. Ex: `localhost` [default: `undefined`]
}
```

@@ -51,6 +51,13 @@ function Server (torrent, opts) {
// deny them
if (req.headers.origin == null) return false

// If a 'hostname' string is specified, deny requests with a 'Host'
// header that does not match the origin of the torrent server to prevent
// DNS rebinding attacks.
if (opts.hostname && req.headers.host !== `${opts.hostname}:${server.address().port}`) {
return false
}

// The user allowed all origins
if (opts.origin === '*') return true

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.